From 732190bb1121e9de08764bb3c33e72ed257dee27 Mon Sep 17 00:00:00 2001
From: SChernykh <sergey.v.chernykh@gmail.com>
Date: Wed, 2 Nov 2022 18:41:16 +0100
Subject: [PATCH] P2PServer: sanity check for timestamps

---
 src/p2p_server.cpp | 31 ++++++++++++++++++++++++++++---
 src/p2p_server.h   |  2 +-
 2 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/src/p2p_server.cpp b/src/p2p_server.cpp
index e98e95f..72a0f3d 100644
--- a/src/p2p_server.cpp
+++ b/src/p2p_server.cpp
@@ -1871,7 +1871,10 @@ bool P2PServer::P2PClient::on_block_response(const uint8_t* buf, uint32_t size)
 		}
 	}
 
-	return handle_incoming_block_async(server->get_block());
+	const SideChain& side_chain = server->m_pool->side_chain();
+	const uint64_t max_time_delta = side_chain.precalcFinished() ? (side_chain.block_time() * side_chain.chain_window_size() * 4) : 0;
+
+	return handle_incoming_block_async(server->get_block(), max_time_delta);
 }
 
 bool P2PServer::P2PClient::on_block_broadcast(const uint8_t* buf, uint32_t size)
@@ -1933,7 +1936,7 @@ bool P2PServer::P2PClient::on_block_broadcast(const uint8_t* buf, uint32_t size)
 
 	m_lastBroadcastTimestamp = seconds_since_epoch();
 
-	return handle_incoming_block_async(block);
+	return handle_incoming_block_async(block, 1800);
 }
 
 bool P2PServer::P2PClient::on_peer_list_request(const uint8_t*)
@@ -2058,10 +2061,32 @@ bool P2PServer::P2PClient::on_peer_list_response(const uint8_t* buf) const
 	return true;
 }
 
-bool P2PServer::P2PClient::handle_incoming_block_async(const PoolBlock* block)
+bool P2PServer::P2PClient::handle_incoming_block_async(const PoolBlock* block, uint64_t max_time_delta)
 {
 	P2PServer* server = static_cast<P2PServer*>(m_owner);
 
+	// Limit system clock difference between connected peers
+	if (max_time_delta) {
+		static uint32_t total_checks = 0;
+		static uint32_t failed_checks = 0;
+
+		++total_checks;
+
+		const uint64_t t = time(nullptr);
+		if ((block->m_timestamp + max_time_delta < t) || (block->m_timestamp > t + max_time_delta)) {
+			LOGWARN(4, "peer " << static_cast<char*>(m_addrString)
+				<< " sent a block with an invalid timestamp " << block->m_timestamp
+				<< " (your local timestamp is " << t << ")");
+
+			++failed_checks;
+			if ((total_checks > 10) && (failed_checks * 4 > total_checks * 3)) {
+				LOGWARN(1, "Your system clock might be invalid: " << failed_checks << " of " << total_checks << " blocks were rejected due to timestamp difference");
+			}
+
+			return true;
+		}
+	}
+
 	if (server->m_pool->side_chain().block_seen(*block)) {
 		LOGINFO(6, "block " << block->m_sidechainId << " (nonce " << block->m_nonce << ", extra_nonce " << block->m_extraNonce << ") was received before, skipping it");
 		return true;
diff --git a/src/p2p_server.h b/src/p2p_server.h
index 73dfb17..90972a2 100644
--- a/src/p2p_server.h
+++ b/src/p2p_server.h
@@ -98,7 +98,7 @@ public:
 		bool on_peer_list_request(const uint8_t* buf);
 		bool on_peer_list_response(const uint8_t* buf) const;
 
-		bool handle_incoming_block_async(const PoolBlock* block);
+		bool handle_incoming_block_async(const PoolBlock* block, uint64_t max_time_delta = 0);
 		void handle_incoming_block(p2pool* pool, PoolBlock& block, const uint32_t reset_counter, const raw_ip& addr, std::vector<hash>& missing_blocks);
 		void post_handle_incoming_block(const uint32_t reset_counter, std::vector<hash>& missing_blocks);