gf4
/
p2pool
mirror of https://github.com/SChernykh/p2pool
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed possible thread handle leak

pull/271/head
SChernykh 2023-08-17 10:16:51 +02:00
parent b3d72cbfcb
commit f3045a5e80
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/tcp_server.cpp
View File

@ -27,7 +27,6 @@ TCPServer::TCPServer(int default_backlog, allocate_client_callback allocate_new_
: m_allocateNewClient(allocate_new_client) : m_allocateNewClient(allocate_new_client)
, m_defaultBacklog(default_backlog) , m_defaultBacklog(default_backlog)
, m_loopThread{} , m_loopThread{}
, m_loopThreadRunning(false)
#ifdef WITH_UPNP #ifdef WITH_UPNP
, m_portMapping(0) , m_portMapping(0)
#endif #endif
@ -474,9 +473,7 @@ void TCPServer::shutdown_tcp()
} }
#endif #endif
if (m_loopThreadRunning.load()) { uv_thread_join(&m_loopThread);
uv_thread_join(&m_loopThread);
}
uv_mutex_destroy(&m_bansLock); uv_mutex_destroy(&m_bansLock);
@ -581,8 +578,6 @@ const char* TCPServer::get_log_category() const
void TCPServer::loop(void* data) void TCPServer::loop(void* data)
{ {
TCPServer* server = static_cast<TCPServer*>(data); TCPServer* server = static_cast<TCPServer*>(data);
server->m_loopThreadRunning.exchange(true);
ON_SCOPE_LEAVE([server]() { server->m_loopThreadRunning.exchange(false); });
log_category_prefix = server->get_log_category(); log_category_prefix = server->get_log_category();

1
src/tcp_server.h
View File

@ -149,7 +149,6 @@ protected:
int m_defaultBacklog; int m_defaultBacklog;
uv_thread_t m_loopThread; uv_thread_t m_loopThread;
std::atomic<bool> m_loopThreadRunning;
static void loop(void* data); static void loop(void* data);